Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bezier approximation #34

Merged
merged 1 commit into from
Jan 11, 2025
Merged

fix bezier approximation #34

merged 1 commit into from
Jan 11, 2025

Conversation

snoyer
Copy link
Owner

@snoyer snoyer commented Jan 11, 2025

Converting arcs to cubic beziers was not accurate and had a straight-up bug when outputting reversed paths

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (0a2a8e3) to head (5d6e8c0).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   99.68%   99.69%           
=======================================
  Files           8        8           
  Lines        1275     1297   +22     
=======================================
+ Hits         1271     1293   +22     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@snoyer snoyer merged commit 01daade into main Jan 11, 2025
18 checks passed
@snoyer snoyer deleted the bezier-approx-fix branch January 11, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants